Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text shifts down and to the right a pixel when rasterized #263

Open
ZMYaro opened this issue Dec 6, 2022 · 3 comments
Open

Text shifts down and to the right a pixel when rasterized #263

ZMYaro opened this issue Dec 6, 2022 · 3 comments
Assignees
Labels
Milestone

Comments

@ZMYaro
Copy link
Owner

ZMYaro commented Dec 6, 2022

No description provided.

@ZMYaro ZMYaro added the bug label Dec 6, 2022
@ZMYaro ZMYaro added this to the v3.4 milestone Dec 6, 2022
@ZMYaro ZMYaro self-assigned this Dec 6, 2022
@ZMYaro
Copy link
Owner Author

ZMYaro commented Dec 6, 2022

It looks as though it may be an issue of certain fonts having letters not line up with pixels at common sizes.

@ZMYaro
Copy link
Owner Author

ZMYaro commented Dec 25, 2022

It still looks like older versions didn't have this issue. My guess is it had to do with the changes to floating regions in v3.3, but I am not 100% sure and haven't found a good solution yet. I am going to push this off to the next version.

@ZMYaro ZMYaro modified the milestones: v3.4, v4.0 Dec 25, 2022
@ZMYaro
Copy link
Owner Author

ZMYaro commented Dec 14, 2023

This seems to be due to padding floating regions out 1 pixel (1 screen pixel, not 1 canvas pixel) in each direction. I can't recall why I did that or why that didn't occur to me while working on v3.4, but removing that seems to fix it. It also fixes the floating region border sometimes being very slightly off from selection content at certain zoom levels. I need to test further to see whether it does breaks something, but hopefully this is it!

ZMYaro added a commit that referenced this issue Dec 14, 2023
This caused HTML text and the region around selections to be slightly off from their canvas rasterized counterparts (#263).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant