Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pnpm instead of npm #74

Closed
adelarsq opened this issue Mar 15, 2021 · 6 comments
Closed

Use pnpm instead of npm #74

adelarsq opened this issue Mar 15, 2021 · 6 comments

Comments

@adelarsq
Copy link

adelarsq commented Mar 15, 2021

It's possible to configure Femto to use PNPM instead of NPM?

@adelarsq adelarsq changed the title Use another tool instead npm (pnpm or yarn) Use pnpm instead of npm Mar 15, 2021
@Zaid-Ajaj
Copy link
Owner

It is possible to add this the same way Femto detects yarn using its lock file. So if a repository has pnpm-lock.yaml we could add make the installation commands execute against pnpm instead. However, I am not sure if pnpm list --json works because that would be how we determine which packages are installed locally since pnpm will not write all packages to node_modules.

I don't have a timeline to implement this, though PRs are more than welcome. This would be blocked by #73 since fixing that would go first

@adelarsq
Copy link
Author

It is possible to add this the same way Femto detects yarn using its lock file. So if a repository has pnpm-lock.yaml we could add make the installation commands execute against pnpm instead. However, I am not sure if pnpm list --json works because that would be how we determine which packages are installed locally since pnpm will not write all packages to node_modules.

Nice!

I don't have a timeline to implement this, though PRs are more than welcome. This would be blocked by #73 since fixing that would go first

Thanks @Zaid-Ajaj. I will try to help on this.

@Zaid-Ajaj
Copy link
Owner

Thanks to #82 this is now implemented as of Femto v0.12 🚀 can you please give it a try? if it works for you we can close the issue 😄

@adelarsq
Copy link
Author

adelarsq commented Oct 25, 2021

@Zaid-Ajaj Nice! I will try on this week

@adelarsq
Copy link
Author

@Zaid-Ajaj Thanks! I forgot to answer. It's working!

@Zaid-Ajaj
Copy link
Owner

@adelarsq Awesome! thanks for confirming 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants