Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow system to produce arbitrary number of points in a trial #138

Open
3 of 4 tasks
raacampbell opened this issue Oct 25, 2023 · 4 comments
Open
3 of 4 tasks

Allow system to produce arbitrary number of points in a trial #138

raacampbell opened this issue Oct 25, 2023 · 4 comments
Labels
high priority major a lot of work needed or task is very general

Comments

@raacampbell
Copy link
Contributor

raacampbell commented Oct 25, 2023

This is largely in place now: f5e8d72 (and: 8991e7a).

  • To enable this, I have used a convolution instead of the ad-hoc interpolation to smooth transition between points. This does not produce identical traces to before, but they are very close indeed. I need to verify that the new approach does not alter the required blanking parameters. If so, we can updated the test waveforms and go with the new system.
  • Also need to check that the laser power is being calculated correctly for smaller number of points.
  • Put in place a system for automatically limiting the number of possible points based on desired laser power, max available laser power, and the blanking time.
  • Get rid of the stimulusDuration option from the stimConfig file. It's going to be complicated to handle, since its max value will depend on the number of stimuli.

The current stimulus pattern is 40 Hz stimulation because we are presenting the stimuli over a 25 ms period.
image

@raacampbell raacampbell added major a lot of work needed or task is very general high priority labels Oct 25, 2023
@raacampbell
Copy link
Contributor Author

Looking on the scope, I see no difference in blanking behavior between the ad-hoc and filtered versions of the command waveforms. Good!

@raacampbell
Copy link
Contributor Author

The convolution is good and does not alter the waveforms in any significant way eca2ede

@raacampbell
Copy link
Contributor Author

See bug #150 related to this new feature.

@raacampbell
Copy link
Contributor Author

It is now very clear in the instructions that the user is responsible for measuring power per point. So maybe we don't need to limit max points.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
high priority major a lot of work needed or task is very general
Projects
None yet
Development

No branches or pull requests

1 participant