Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show more than 1 MB of google cloud test logs #5361

Closed
teor2345 opened this issue Oct 7, 2022 · 1 comment · Fixed by #5367
Closed

Show more than 1 MB of google cloud test logs #5361

teor2345 opened this issue Oct 7, 2022 · 1 comment · Fixed by #5367
Labels
A-devops Area: Pipelines, CI/CD and Dockerfiles A-diagnostics Area: Diagnosing issues or monitoring performance C-bug Category: This is a bug S-needs-investigation Status: Needs further investigation

Comments

@teor2345
Copy link
Contributor

teor2345 commented Oct 7, 2022

Motivation

In PR #5358, we limited Google Cloud jobs to the last 1MB of test logs, to avoid a GitHub Actions output limit:
https://docs.github.com/en/actions/creating-actions/metadata-syntax-for-github-actions#outputs-for-docker-container-and-javascript-actions

Designs

We could use log artifacts:
https://docs.github.com/en/actions/using-workflows/storing-workflow-data-as-artifacts

Or modify the ssh-compute GitHub action so it shows the SSH output:
google-github-actions/ssh-compute#29

@teor2345 teor2345 added C-bug Category: This is a bug A-devops Area: Pipelines, CI/CD and Dockerfiles S-needs-triage Status: A bug report needs triage S-needs-investigation Status: Needs further investigation A-diagnostics Area: Diagnosing issues or monitoring performance labels Oct 7, 2022
@teor2345
Copy link
Contributor Author

teor2345 commented Oct 7, 2022

We'll need to try the solution in PR #5358, before we know how important this ticket is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-devops Area: Pipelines, CI/CD and Dockerfiles A-diagnostics Area: Diagnosing issues or monitoring performance C-bug Category: This is a bug S-needs-investigation Status: Needs further investigation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants