Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make getblocktemplate-rpcs a default feature #7361

Closed
2 of 3 tasks
Tracked by #7366
teor2345 opened this issue Aug 21, 2023 · 1 comment · Fixed by #7740
Closed
2 of 3 tasks
Tracked by #7366

Make getblocktemplate-rpcs a default feature #7361

teor2345 opened this issue Aug 21, 2023 · 1 comment · Fixed by #7740
Assignees
Labels
A-rpc Area: Remote Procedure Call interfaces A-rust Area: Updates to Rust code C-feature Category: New features

Comments

@teor2345
Copy link
Collaborator

teor2345 commented Aug 21, 2023

Post-Merge TODOs

  • Describe this newly stabilised feature in the CHANGELOG
  • Arborist announcement
  • Forum update

Motivation

Once we're happy to support the getblocktemplate RPCs, we can turn them on in all Zebra builds, by adding that feature to the default feature list:

zebra/zebrad/Cargo.toml

Lines 53 to 55 in 31426f3

[features]
# In release builds, don't compile debug logging code, to improve performance.
default = ["release_max_level_info"]

Specifications

https://doc.rust-lang.org/cargo/reference/features.html#the-default-feature

Complex Code or Requirements

This is a well-supported Cargo configuration.

Testing

Some tests might need updates if they assume getblocktemplate-rpcs will always be disabled during the test. We should probably delete or disable those tests (ticket #7362).

@teor2345 teor2345 added A-rust Area: Updates to Rust code S-needs-triage Status: A bug report needs triage A-rpc Area: Remote Procedure Call interfaces C-feature Category: New features P-Medium ⚡ labels Aug 21, 2023
@mpguerra
Copy link
Contributor

Hey team! Please add your planning poker estimate with Zenhub @arya2 @oxarbitrage @teor2345 @upbqdn

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rpc Area: Remote Procedure Call interfaces A-rust Area: Updates to Rust code C-feature Category: New features
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants