Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(clippy): last lints #8855

Merged
merged 1 commit into from
Sep 6, 2024
Merged

fix(clippy): last lints #8855

merged 1 commit into from
Sep 6, 2024

Conversation

oxarbitrage
Copy link
Contributor

Motivation

Right now, we have some clippy failures what we need to fix/workaround in order to merge pull requests.

Solution

Fix/workaround lints.

PR Author's Checklist

  • The PR name will make sense to users.
  • The PR provides a CHANGELOG summary.
  • The solution is tested.
  • The documentation is up to date.
  • The PR has a priority label.

PR Reviewer's Checklist

  • The PR Author's checklist is complete.
  • The PR resolves the issue.

@oxarbitrage oxarbitrage added I-build-fail Zebra fails to build P-High 🔥 labels Sep 6, 2024
@oxarbitrage oxarbitrage requested review from a team as code owners September 6, 2024 12:08
@oxarbitrage oxarbitrage requested review from upbqdn and removed request for a team September 6, 2024 12:08
@github-actions github-actions bot added the C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG label Sep 6, 2024
@mergify mergify bot merged commit 1511997 into main Sep 6, 2024
135 checks passed
@mergify mergify bot deleted the fix-clippy-lints-09-24 branch September 6, 2024 15:24
@oxarbitrage oxarbitrage mentioned this pull request Oct 10, 2024
Merged
43 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@conradoplg conradoplg conradoplg approved these changes

@upbqdn upbqdn Awaiting requested review from upbqdn upbqdn is a code owner automatically assigned from ZcashFoundation/network-reviewers

Assignees
No one assigned
Labels
C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG I-build-fail Zebra fails to build P-High 🔥
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oxarbitrage @conradoplg