suggestion to don't clone self in get_block

[oxarbitrage]

Motivation

In #9006 we are cloning self in the get_block implementation which could bring some problems in some tests.

Solution

This is an alternative to do that that @conradoplg might find useful, feel free to discard.

[arya2]

Optional/Nitpick/Subjective: This may actually be a little less readable, but it's tempting to use then() here.

Suggested change

	let get_block_header_future = if matches!(verbosity, 1 | 2) {
	Some(self.get_block_header(original_hash_or_height.clone(), Some(true)))
	} else {
	None
	};
	let get_block_header_future = matches!(verbosity, 1 | 2)
	.then(|| self.get_block_header(original_hash_or_height.clone(), Some(true)));

[arya2]

@conradoplg There's very little in RpcImpl being cloned but this looks like a good cleanup if you'd like to merge it into your PR. @oxarbitrage This could be a good change to include in your jsonrpsee PR if the base branch merges without it.

[conradoplg]

Thanks! I'm not sure if this will solve the issues I'm getting implementing #9024 but I'll give it a shot there, inspired on this approoach.