Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Close icon does not load #281

Closed
amr-coding opened this issue Apr 25, 2021 · 18 comments · Fixed by #297
Closed

Close icon does not load #281

amr-coding opened this issue Apr 25, 2021 · 18 comments · Fixed by #297
Assignees
@matiasperrone
Labels
bug help wanted more info When the mainteners need more info about an issue

Comments

@amr-coding
Copy link

Describe the bug
A clear and concise description of what the bug is.
After installing the package and importing it, everything seems to work but the icons is not working.

I checked the computed styles on my browser I found the background styles that contains the svg icons path, I hovered over the path of the svg icon and it shows "Could not load the image".

The path looks like this: http://localhost:8000/images/vendor/vue-hotel-datepicker/dist/ic-arrow-right-datepicker.regular.99ab0620.svg?38d376a780635ae10e835c1c1a66cac8

I'm currently using Laravel with Vue.js for development

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'the date-picker input'
  2. Click on the input field
  3. Icons can't be loaded and that is the error

Expected behavior
The package icons should be loaded in the date picker.

Screenshots
Capture

Desktop (please complete the following information):

  • OS: [Windows 10]
  • Browser [chrome, firefox]
  • Version [89.0b2 (64-bit)]
@matiasperrone
Copy link
Collaborator

Whet version are you using??

@matiasperrone matiasperrone self-assigned this Apr 26, 2021
@matiasperrone matiasperrone added the more info When the mainteners need more info about an issue label Apr 26, 2021
@erenergul
Copy link

Same for me as well. I installed today latest version v4.3
fonts/vendor/vue-hotel-datepicker/dist/img/ic-arrow-right-green.regular.83ed3b6c.svg?83ed3b6cd733b2b6d8fcf86389fbbbc9 404 (Not Found)
This is my console error.

@matiasperrone
Copy link
Collaborator

Please try the last version (v4.4)

@erenergul
Copy link

Im sorry but it looks last version v4.3 - I couldn't see v4.4.

@matiasperrone
Copy link
Collaborator

Version v4.4 is now available!

@qayumhasan
Copy link

not working. i install "vue-hotel-datepicker": "^4.4.0", but Icons can't be loaded

@qayumhasan
Copy link

may be icons path can not found if project load from subfolder

@matiasperrone
Copy link
Collaborator

Thanks guys for testing... anyone of you can fix it? I can publish a new version but I am a little swamp right now in my paid work. I promise to fix it soon... probably during the weekend.

@amr-coding
Copy link
Author

Thanks guys for testing... anyone of you can fix it? I can publish a new version but I am a little swamp right now in my paid work. I promise to fix it soon... probably during the weekend.

Thanks for your efforts,
As I'm using Laravel the assets is required to be in the folder Public, so I moved the package assets to the Public folder and by doing that it worked just fine.

Usually when I install any package in any of my projects, I don't move any of the assets from the packages folders to the Public folder, so it's just in this case I encounter this problem and the only solution I could make is to move the assets from the package /src folder to the Laravel /public folder.

Anyways, I appreciate your efforts for building hotel date picker with such a great design.

@stale
Copy link

stale bot commented Jun 22, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jun 22, 2021
@develth
Copy link
Contributor

develth commented Jun 24, 2021 •
edited
Loading

Hi,

seems like the mentioned icons work.
But i recognized, that the lcose icon is missing (404). Regardless of the svg in Project doesn´t shows anything.

Using 4.4.0

@matiasperrone
Copy link
Collaborator

They are not been packed by webpack... do you how to fix this? please PR if you can.

@matiasperrone
Copy link
Collaborator

A new version was pushed v4.4.2 please try again and let me know

@seking01
Copy link

this is still not fixed in v4.4.2. Close X is still missing

@matiasperrone
Copy link
Collaborator

Can you PR us with the fix? or some way of testing this... because I don't have much to fix it

@matiasperrone matiasperrone reopened this Jul 26, 2021
@matiasperrone matiasperrone mentioned this issue Jul 27, 2021
Closed
@matiasperrone matiasperrone changed the title Icons can't be loaded Close icon does not load Jul 27, 2021
@matiasperrone
Copy link
Collaborator

@develth and/or @insek, if you want you can PR the solution. I don't have the time right now to fix it.

@austinziza
Copy link

any solution yet for this error, it is displaying an x button but cant load the image

@matiasperrone
Copy link
Collaborator

Not yet, A Pull Request is welcome!

@develth develth mentioned this issue Aug 9, 2021
Merged
matiasperrone added a commit that referenced this issue Aug 9, 2021
@matiasperrone
version bump
98934d6 
#297: Fixed #281 
Thanks Tomas @develth!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matiasperrone matiasperrone

Labels
bug help wanted more info When the mainteners need more info about an issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fixed close.svg and placed it inline to prevent asset issue develth/vue-hotel-datepicker
7 participants
@matiasperrone @develth @seking01 @erenergul @qayumhasan @amr-coding @austinziza