Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: Show week number #81

Closed
webartistse opened this issue Jul 7, 2018 · 19 comments · Fixed by #317 or #319
Closed

Suggestion: Show week number #81

webartistse opened this issue Jul 7, 2018 · 19 comments · Fixed by #317 or #319
Assignees
Milestone

Comments

@webartistse
Copy link

Would like option to show the number of the week to the left in the calendar. Very common that you relate to the week number in parts of Europe.

@amulchinock
Copy link
Contributor

@webartistse Could you elaborate?

Do you mean that the datepicker should show the current week in the year, when selecting dates?
(i.e https://www.epochconverter.com/weeks/2018)

@webartistse
Copy link
Author

@amulchinock Sure! Many apps or components solves this by adding some label or similar on the current row. I attached an example here how Calendar in MacOS shows this. The reason many users needs this is that its common to say/know that you have vacation week 28-31 but you dont know exact dates. At least this is common in Scandinavia and some parts of europe.

macos calendar

@amulchinock
Copy link
Contributor

@webartistse Ahh - I think I understand.
So, if I said that I was going on holiday from the 9th to the 16th of October 2018 - I could also be more vague and say that I was going from the 41st - 42nd week?

@webartistse
Copy link
Author

@amulchinock yeah, exactly! Nobody says "I have vacation 9-29 july. You say "I have vaction week 28-30". You only talk date when its a specific day or less than 7 days.

@amulchinock
Copy link
Contributor

amulchinock commented Oct 10, 2018

@webartistse Interesting! In British English (I'm from England), we'd say something along the lines of "I'm going on holiday around the 25th of October, for two weeks".

In your opinion, what would be the best way of handling this? We could create a property for the datepicker for showing week numbers (something like :showWeekNumbers="someVariable_or_String"
Where someVariable_or_String = Boolean
Would that work for you?

I'd be interested to hear @krystalcampioni view on this :)

@krystalcampioni
Copy link
Member

Interesting! I've been to Stockholm recently and a friend was also talking about how week numbers are used there, even for parking signs. I think a boolean prop showWeekNumbers would make sense for this 👍

@webartistse
Copy link
Author

@amulchinock @krystalcampioni That would be awesome!

@matiasperrone matiasperrone added this to the v3.0.0 milestone Jan 27, 2020
@matiasperrone matiasperrone self-assigned this Jan 27, 2020
@matiasperrone
Copy link
Collaborator

Hi guys! seems that this feature went 🧊.

I am working on v3. I think it should be easier to add it if you provide me with a PR... still interested?

@kasperlegarth
Copy link
Contributor

What is the status of this? :)
I would like to see this feature implemented as well.

@matiasperrone
Copy link
Collaborator

Hi! this I think more for v4.1 (v4.0 is right around the corner).
v4 will have a complete rewrite in html and many bugfixes. I am waiting a PR anytime...

@matiasperrone
Copy link
Collaborator

Also I didn't have the time.

@matiasperrone matiasperrone modified the milestones: v3.0.0, v4 Aug 27, 2020
@mariusa
Copy link

mariusa commented Sep 23, 2020

In British English (I'm from England), we'd say something along the lines of "I'm going on holiday around the 25th of October, for two weeks".

Same here in Romania. I never heard people saying "going on week 37" -- huh?

@matiasperrone
Copy link
Collaborator

Same here in Argentina, but there are a number of countries.

@matiasperrone matiasperrone removed this from the v4 milestone Sep 24, 2020
@matiasperrone
Copy link
Collaborator

I am sorry but I am going to remove this feature from the v4 in order to be able to finish the final release

@matiasperrone matiasperrone added this to the v5 milestone Dec 23, 2020
@matiasperrone matiasperrone removed their assignment Dec 24, 2020
@kasperlegarth
Copy link
Contributor

@matiasperrone I have taken the liberty to take this task on me. As I could see it was hard (understandable) for you to find the time for this task.
I hope my code is clear and obvious, or let me know so I can make the needed adjustments.

For any fellow Scandinavians, it is us that need this functionality the most, the implementation of the week numbers is pretty well tested. I first implemented this a few years ago on the "sol og strand" website In the booking bar on the front page. There have been no bugs to my knowledge with the week numbers in the two years' time.

@matiasperrone
Copy link
Collaborator

matiasperrone commented Sep 5, 2022

I am checking out PR #317 to solve this enhancement.

@matiasperrone
Copy link
Collaborator

Done in v4.6

@matiasperrone matiasperrone self-assigned this Dec 29, 2022
@matiasperrone matiasperrone modified the milestones: v5, v4, v4.6 Dec 29, 2022
@matiasperrone
Copy link
Collaborator

working on the build please wait

@matiasperrone
Copy link
Collaborator

@webartistse @mariusa @krystalcampioni @amulchinock I hope this bring joy!
Happy new year!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment