Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Material 1.0.x support #36

Open
yanickrochon opened this issue Sep 18, 2017 · 5 comments
Open

Material 1.0.x support #36

yanickrochon opened this issue Sep 18, 2017 · 5 comments

Comments

@yanickrochon
Copy link

At some point, Material v1.0.x will have to be supported because the project is already at the pre-release stage at this time.

I don't see a lot of breaking changes, apart from the obvious color API changes.

@yanickrochon
Copy link
Author

I have attempted rewriting the component, and it's a little more than fixing imports. I would also replace FontAwesome with actual React components, notably icons from mdi-material-ui

@yanickrochon
Copy link
Author

First commit, here for testing. I did remove unnecessary dependencies (probable fix for #34?) Did not implement the PR #33.

Comments welcome, and hopefully a PR whenever possible.

@PolGuixe
Copy link
Contributor

I agree we need to move to Material-UI 1.0.x. I'll try to get some work done on this in the coming weeks as I need it for a project.

I'll have a look at PR #33.

@yanickrochon
Copy link
Author

yanickrochon commented Oct 23, 2017

Great! I just started a project and need it as well. As I upgraded my branch to 1.x of MUI, there is now a Grid component that should be part of the default layout, and I wil make another commit, tonight about this. Comments welcome! If all is alright with you, this branch can then be merged into a next branch in this repository and continue to work from there. I'm more than happy to contribute.

@yanickrochon
Copy link
Author

What's the status of this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants