Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update config.example.py not to contain a hardcoded secret #223

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update config.example.py not to contain a hardcoded secret #223

wants to merge 1 commit into from

Conversation

TomNaessens
Copy link
Member

@TomNaessens TomNaessens commented May 20, 2024 •
edited
Loading

Closes #222

@TomNaessens TomNaessens requested a review from FKD13 May 20, 2024 18:54
@FKD13
Copy link
Member

FKD13 commented May 20, 2024

Don't know if they are used for production, but the docker compose files should contain this variable as well? What default should we use there?

@TomNaessens TomNaessens mentioned this pull request May 20, 2024
Open
@FHantke
Copy link

FHantke commented May 20, 2024

Hi, thanks for addressing the issue. Regarding the compose file, I'd suggest using the option to show errors on missing variables: https://docs.docker.com/compose/compose-file/12-interpolation/

@redfast00
Copy link
Member

In prod, we use passenger, not docker, so we should be fine to merge & "deploy" this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FKD13 FKD13 Awaiting requested review from FKD13

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hardcoded secret key
4 participants
@TomNaessens @FKD13 @FHantke @redfast00