Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

why first iteration not use thershold in test code #45

Open
yongqis opened this issue Aug 18, 2023 · 1 comment
Open

why first iteration not use thershold in test code #45

yongqis opened this issue Aug 18, 2023 · 1 comment

Comments

@yongqis
Copy link

yongqis commented Aug 18, 2023

I wonder why the first iteration not use thershold in connected_components_constraint(vertex, max_sz) / graph_propagation() /graph.py?

Is the experiment in the paper also based on this setting?

I find that the first iteration result 'remain' may be 'null', so code will not do the next iteration and finally clustering result has nothing to do with the model's predict.

For the first iteration:
the 'vertex' contains all the node-pairs/links/edges are generated by KNN and also are the input data of model,
and the code just directly use all these node-pairs/links (neighbors = n.links, line 69) to create groups/cluster, just like BFS algorithm, rather than use the score predicted by the model to filter them. Is it right?

I would be very grateful if you could provide suggestion.

@yongqis
Copy link
Author

yongqis commented Aug 23, 2023

I find the original code ( https://github.com/XiaohangZhan/cdp/blob/master/source/cdp.py 73-88 line) have a 'pair selection' step, so that they use none thershold in the first iteration.
but no similar step was found in this code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant