Feature/update last prices improve #705
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some days ago i contributed to the project with the same idea - improve fetching needed data via Promise.allSettled. After you approved and merged my PR, i become interested where can i improve more. And i found some places where we can improve performance by the same way.
Maybe you think it'll overload your redis, but i have solutuon in this case - add over the redis message broker like rabbit or kafka and i guess all will be working fine.
Basically here i improved only two functions -- updateMarketSummarys and updateLastPrices. All another changes made by prettier (with repo's prettierc config)