Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] ZiggyCreatures.FusionCache.MicrosoftHybridCache Dependency on Microsoft.Extensions.Caching.Hybrid #340

Open
pwelter34 opened this issue Dec 11, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@pwelter34
Copy link

Describe the bug

The nuget package ZiggyCreatures.FusionCache.MicrosoftHybridCache has a dependency on Microsoft.Extensions.Caching.Hybrid. However, the HybridCache abstraction is in the Microsoft.Extensions.Caching.Abstractions package. Do you really need to reference Microsoft.Extensions.Caching.Hybrid? If you use the Microsoft.Extensions.Caching.Abstractions package, you have the advantage of using a released and supported dependency.

Expected behavior

Reference Microsoft.Extensions.Caching.Abstractions instead of Microsoft.Extensions.Caching.Hybrid

@pwelter34
Copy link
Author

To further the discussion, do you really need the separate ZiggyCreatures.FusionCache.MicrosoftHybridCache package? ZiggyCreatures.FusionCache already has a reference to Microsoft.Extensions.Caching.Abstractions

@jodydonetti
Copy link
Collaborator

jodydonetti commented Dec 11, 2024

Hi @pwelter34

Describe the bug

The nuget package ZiggyCreatures.FusionCache.MicrosoftHybridCache has a dependency on Microsoft.Extensions.Caching.Hybrid. However, the HybridCache abstraction is in the Microsoft.Extensions.Caching.Abstractions package. Do you really need to reference Microsoft.Extensions.Caching.Hybrid? If you use the Microsoft.Extensions.Caching.Abstractions package, you have the advantage of using a released and supported dependency.

Thanks for pointing this out, I think you're right: I just need to update the current package reference to Microsoft.Extensions.Caching.Memory to 9.0.0 (which in turn depends on Microsoft.Extensions.Caching.Abstractions), so that should be enough.
Will update the package refs in the next preview.

To further the discussion, do you really need the separate ZiggyCreatures.FusionCache.MicrosoftHybridCache package? ZiggyCreatures.FusionCache already has a reference to Microsoft.Extensions.Caching.Abstractions

This is something I'm still playing with: I started separating it, now I'm finalizing all the other details, but I may end up not requiring that.
In that case (anyway before v2 goes GA, of course) I'll just mark the new separate package as deprecated and include everything into the main one.
I think I have to doublecheck with Marc (Gravell) too, because at first we agreed upon having a separate package for the integration, so maybe I'm missing something right now.

Will update, thanks again!

@jodydonetti jodydonetti self-assigned this Dec 11, 2024
@jodydonetti jodydonetti added this to the v2.0.0 milestone Dec 11, 2024
@jodydonetti jodydonetti added the enhancement New feature or request label Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants