Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows compilation error #44

Open
mmhancxt opened this issue Jul 5, 2023 · 3 comments
Open

Windows compilation error #44

mmhancxt opened this issue Jul 5, 2023 · 3 comments

Comments

@mmhancxt
Copy link

mmhancxt commented Jul 5, 2023

Hi,
I tried to compile release 2.2.6 under Windows 10 with MSVC 141. But I failed with several compilation errors:

src\directorycollection.cpp(295): error C2039: 'getName': is not a member of 'zipios::FilePath' ...
error C2065: 'm_findInfo': undeclared identifier
error C2065: 'f_read_first': undeclared identifier

I checked your code but didn't succeed in finding definition of these variables.

My cmake command is :
cmake -G "Visual Studio 17 2022" -DCMAKE_BUILD_TYPE=Debug -DCMAKE_PREFIX_PATH=/path/to/zlib -DCMAKE_INSTALL_PREFIX=/path/to/install ..

Could you provide any help please?

Best regards,

@AlexisWilke
Copy link
Contributor

I applied a quick patch. It should at least resolved the errors you just reported.

Note that we don't really support the Windows (or Mac OS) version. But that one file should go through now.

@mmhancxt
Copy link
Author

mmhancxt commented Jul 6, 2023

Hi Alexis,
Thanks for your update and your information.
I tried with your commit but it still fails.
Errors :
directorycollection.cpp(290): 'm_findinfo' undelcalred
directorycollection.cpp(320): 'int _findnext64(... ... ) : cannot convert argument 2
dosdatetime.cpp(555): localtime_r identifier not found
gzipoutputstream.cpp(65): no default contructor available
zipinputstreambuf.cpp(131): 'min' is not a member of 'std'
... ...

There're still other errors that I do not list here.
We were using version 0.1.5 and it compiles under Windows. Do you have any idea since when Windows is no longer supported?

Best regards,
Liang

@AlexisWilke
Copy link
Contributor

I fixed the few you presented here (I think) except the one on line 65 (not enough info for that one).

I've not worked on MS-Windows for a long time. I never tried to get zipios to compile on that OS. We only use it on Linux... I kept the code for Windows in #if/#endif blocks, but never tried it...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants