Code review summary by Shuang Zhao

[ShuangZhao95]

Hi Hairstyle team,

Since my computer system is Windows, I cannot run the code in my computer to simulate this app. My teammate shows the simulation of your work which is very fancy. However it seems that there are some small problems about simulating your app, in my teammate's computer he cannot access the photoes in the simulation app. For me, I just read some essential codes in your github.

First, I see the codes about the algorithm you used in the grabcutios-master. I can see that you used a lot of algorithms and functions of OpenCV. If you can add some comments on each functions it will be easier for people to read your code. In GrabCutManager.mm, from line 167 to line 183. The codes here seems to be duplicated, maybe you can avoid duplication by change the if, else if into cases, that will be better. The same problem happens in line 206 to line 223. In line 243, I can see that you used the function grabCut in OpenCV, after that it seems to be some process of your picture, it will be better if you can add more commets about these section. On top of this file, in ViewController.mm there are couple problems about the if, else if thing.

Then I check the codes about your UI, there are so many files there, for me who do not have much experience about UI, I am not sure whether I found the importent part of your code. Maybe beacuse my computer is windoes and you implemented your app with IOS system. If you can add some more instructions in your readme file, it will be more clear. It seems that you used swift code to implement this. I saw these swift codes, it seems that you are adding some functions in there files, I think it will be better if you can add some comments after some functions. Maybe because my computer system is windows I don't know how to access to the xcuserstate file created by each of you.

When I looked at the GrabCutManager.mm, I think it is a good way to write the elements of the function in several lines, some elements' name is long, if people just write all of them in one line it will be hard to identify each of them. From the demo you showed in the presentatioin, its really cool that you can extract the hair part of a picture, It seems hard to merge different kind of hairstyles into someone's head, I am looking forward to seeing the final version of your app with all functions, good luck~