Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code review for HairStyle #15

Open
zzx0921 opened this issue Nov 13, 2017 · 0 comments
Open

Code review for HairStyle #15

zzx0921 opened this issue Nov 13, 2017 · 0 comments

Comments

@zzx0921
Copy link
Collaborator

zzx0921 commented Nov 13, 2017

Your project is amazing and I can tell that you guys really did a lot for this app. Your Github is well-organized, which makes it easier to understand the structure of your app. I tried to run your code on my computer and here are some suggestions:

  1. When I ran the FaceDetector, at the sign in page, I think maybe you can add a notification to users when they typed wrong password or something wrong happened. It will make your app more user-friendly.

  2. For the GrabCutIOS, the test image is an image of tower. I tried to upload photos of human faces to test the function of your app. But since there were no photos with human faces in the photo album of my simulator, I couldn't tell if your app works well with human faces. With the test image of tower, your app works great.

  3. Your camera button didn't work very well. Maybe it is what you guys plan to do in sprint 3, so I'm looking forward to the new function of your app.

  4. In some of your code, there are some comments which seem to be useless. Maybe you should delete these useless comments so that your code can be terser.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant