John Curci Code Review 2

[ThePrefixCyber]

First of all, it seems that your code is not fully uploaded to Github, because some files were missing and I couldn't run the project. Your code was working before so I recommend you figure out what has changed. Instead of running your code I have looked through it by hand.

The first thing I have noticed is that there are still not very many comments. Also, there are many files and only a fraction of them are your originals, but I had to open the files and look for the author listing at the top to figure out which was which. It would be nice if you would indicate this somehow.

I think one technical weakness of your project is that, judging by what was on Github, you're only operating on a very small number of images. I would recommend testing your code on many more images to make sure it actually works in the general case.

Regarding functionality, you are in good shape because you have almost exclusively used existing functions and libraries to do everything. This is good for performance and reliability.

Your ReadMe files are excellent, although, as I said, some of the files seem to be missing so I was not able to confirm that the steps in the ReadMe actually allow me to run the code.

Also, there are many style errors in your code, which reduce the readability. For example many lines are too long and require the user to scroll the window over. I would recommend running the Swift style checker Swiftlint. This can be installed via Homebrew:

brew install swiftlint

and then can be used by navigating to the directory containing your code and running the command

swiftlint lint

This will recursively move through the directory and check all of your files. Running this, I did not find any errors, but I found plenty of warnings. Swiftlint also has an autocorrect feature that will fix all this for you.

Overall I would say you are in decent shape.

//John Curci