ResetPassword not Working #482
Labels
Comments
|
Following |
|
I will take a look at this asap. You should be using Confide 4 you know. |
|
I use "zizaco/confide": "~4.3@dev", and still have the reset password bug, dunno why |
gabrielalmeida
added a commit
to gabrielalmeida/confide
that referenced
this issue
Mar 8, 2015
Relates to Zizaco#482 Password reset used to be validated by the same ruleset that any regular update, so it was going to fail everytime because instead of sending required fields for update ruleset validation Confide was only sending password and password_confirmation. This PR adds a method on ConfideUser that provides a boolean to be checked at save method and change the ruleset to 'password_reset' which requires only password and password_confirmation to pass on. Due to this boolean variable that needs to get passed on passwordReset UserRepository suffered minor rewriting. This PR also allows all accordingly validation messages to be sended to final user instead of only showing him a generic Confide Lang defined error message. Dunno if this will break any tests, take it as a proposal template if so.
gabrielalmeida
added a commit
to gabrielalmeida/confide
that referenced
this issue
Mar 8, 2015
Relates to Zizaco#482 Password reset used to be validated by the same ruleset that any regular update, so it was going to fail everytime because instead of sending required fields for update ruleset validation Confide was only sending password and password_confirmation. This PR adds a method on ConfideUser that provides a boolean to be checked at save method and change the ruleset to 'password_reset' which requires only password and password_confirmation to pass on. Due to this boolean variable that needs to get passed on passwordReset UserRepository and UserController suffered minor changes. This PR also allows all accordingly validation messages to be sended to final user instead of only showing him a generic Confide Lang defined error message. Dunno if this will break any tests, take it as a proposal template if so.
gabrielalmeida
added a commit
to gabrielalmeida/confide
that referenced
this issue
Mar 8, 2015
Relates to Zizaco#482 Password reset used to be validated by the same ruleset that any regular update, so it was going to fail everytime because instead of sending required fields for update ruleset validation Confide was only sending password and password_confirmation. This PR adds a method on ConfideUser that provides a boolean to be checked at save method and change the ruleset to 'password_reset' which requires only password and password_confirmation to pass on. Due to this boolean variable that needs to get passed on passwordReset UserRepository and UserController suffered minor changes. This PR also allows all accordingly validation messages to be sended to final user instead of only showing him a generic Confide Lang defined error message. Dunno if this will break any tests, take it as a proposal template if so.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I saw another issue (#286) about this, but the solution posted does not work.
I am on Confide 3.2.3, laravel 4.2 and the following line in ConfideUser.php will always return false. Looks like a problem with the release, but when I try any other version I have problems (like Zizaco/Confide/ConfideUser not found)...
Ideas?
The text was updated successfully, but these errors were encountered: