Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metricName type description #266

Open
peterpeterparker opened this issue Aug 16, 2024 · 0 comments
Open

metricName type description #266

peterpeterparker opened this issue Aug 16, 2024 · 0 comments

Comments

@peterpeterparker
Copy link

peterpeterparker commented Aug 16, 2024

Hi 👋

Thanks for the great library!

I noticed that the information metricName of IAnalyticsTrackerOptions wasn't stricly typed and defined as string. I'm not sure if there's a particular reason for this, but if not, I think it would be helpful to strongly type it. At least for me, as someone discovering and starting to use the library, this would have been helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant