Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace formatting parser #11

Open
DaRacci opened this issue Nov 21, 2022 · 5 comments
Open

Replace formatting parser #11

DaRacci opened this issue Nov 21, 2022 · 5 comments
Labels
enhancement New feature or request

Comments

@DaRacci
Copy link

DaRacci commented Nov 21, 2022

The colour and formatting parser should be replaced with MiniMessage which is cleaner, faster, and more user friendly. Most if not all plugins especially new are moving to minimessage which is now officially supported by paper and used as the message formatting standard.

@DaRacci
Copy link
Author

DaRacci commented Nov 21, 2022

Will probably require a user warning, auto convertor or some form of user notice about the change so end users are not confused to why their lang files are no longer supported in the current format.

@mrfloris
Copy link
Contributor

Just a side note,

While supported by Paper, CMI does currently support Spigot, which does not have MiniMsg, meaning CMI would have to still fall back.

But yes, it would be nice since MiniMsg is baked into Paper, that at some point it could clean up CMI and other zrips plugins by using minimsg instead. But I do feel this has to still work on Spigot, or Spigot support has to be dropped 100% (which I don't mind, personally).

@DaRacci
Copy link
Author

DaRacci commented Jan 27, 2023

Just a side note,

While supported by Paper, CMI does currently support Spigot, which does not have MiniMsg, meaning CMI would have to still fall back.

But yes, it would be nice since MiniMsg is baked into Paper, that at some point it could clean up CMI and other zrips plugins by using minimsg instead. But I do feel this has to still work on Spigot, or Spigot support has to be dropped 100% (which I don't mind, personally).

I agree that dropping spigot is something that can benefit almost all plugins but we wouldn't be able to drop support since spigot requires you to support plain spigot to be listed on spigotmc still I believe.

An alternative would be using a solution which can download libraries at runtime such as the library I maintain slimjar, it would download and mount the adventure libraries if they aren't present in the class path already, meaning on spigot it will download them, on paper it would just work.

@mrfloris
Copy link
Contributor

CMILib is already a library, people complain about having a dependency, I don't think offering more will help. I am even trying to get the economy stuff inside cmilib just so we don't need injector, or some custom compile of vault.
(/offtopic)

@DaRacci
Copy link
Author

DaRacci commented Jan 28, 2023

CMILib is already a library, people complain about having a dependency, I don't think offering more will help. I am even trying to get the economy stuff inside cmilib just so we don't need injector, or some custom compile of vault.
(/offtopic)

The slimjar library isn't a plugin itself, it needs to be shaded into the plugin, it doesn't have any dependencies and has a very small footprint

@Zrips Zrips added the enhancement New feature or request label May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants