Skip to content
This repository has been archived by the owner on Aug 24, 2021. It is now read-only.

bug: Fix list view test #53

Open
tayronemachadozup opened this issue Mar 22, 2021 · 2 comments
Open

bug: Fix list view test #53

tayronemachadozup opened this issue Mar 22, 2021 · 2 comments
Assignees
Labels
angular bug Something isn't working tests

Comments

@tayronemachadozup
Copy link
Contributor

At the moment listview tests are failing because we were unable to run them in headless mode. For this to be possible, we need to define a fixed size for the viewport performed by the test.

@tayronemachadozup tayronemachadozup added bug Something isn't working angular labels Mar 22, 2021
@igorgiumellizup
Copy link
Contributor

igorgiumellizup commented Jul 9, 2021

The viewport issue was fixed here.
Now we need to update the list view tests considering:

  • Update the list view reference screenshots using this lib. This way the screenshot size will be the same when running headless locally and on CI/CD (GitHub Actions)
  • Review what screens we are using for comparison. I noticed that some are too specific and hard to compare, for example, comparing scrolling a list by some % is very flaky. We need to use another approach.

@igorgiumellizup igorgiumellizup self-assigned this Jul 9, 2021
@igorgiumellizup
Copy link
Contributor

Depends on ZupIT/beagle-web-angular#280

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
angular bug Something isn't working tests
Projects
None yet
Development

No branches or pull requests

2 participants