Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Article Audit: Use skip navigation links #773

Open
alexroseb opened this issue Apr 21, 2019 · 5 comments
Open

Article Audit: Use skip navigation links #773

alexroseb opened this issue Apr 21, 2019 · 5 comments
Labels
article audit good first issue A small, good place to get started working with the site. post Article submissions and edits.

Comments

@alexroseb
Copy link
Member

Reviewed as per #669. This article should be a little more fleshed out and some of the information seems a bit outdated (specifically the section about the JavaScript polyfill).

@alexroseb alexroseb added post Article submissions and edits. good first issue A small, good place to get started working with the site. article audit labels Apr 21, 2019
@alexroseb alexroseb added this to the Content Updates for 2019 milestone Apr 21, 2019
@p2635
Copy link
Contributor

p2635 commented Feb 26, 2023

Hi @alexroseb @ericwbailey , I'm looking for good first issues to work on. Is there anything outstanding on this? It looks done to me.

@ericwbailey
Copy link
Member

One thing I'm thinking would be helpful for this post in particular would be explaining the different behaviors a screen reader would perform depending on if the skip link target is a landmark container or a heading element.

Is this something you'd be interested in clarifying, @p2635?

@p2635
Copy link
Contributor

p2635 commented Feb 28, 2023

Hi @ericwbailey, I'm still new to accessibility to be honest and contributing to open source projects. I'm slowly building my confidence now.

Explaining the different behaviors a screen reader would perform depending on if the skip link target is a landmark container or a heading element.

Forgive me for being ignorant but I'm a bit confused actually 😕 . I don't see a difference, because a skip link goes to wherever you define it right? (Other than the announcement maybe) Are you referring to general navigation between landmarks vs navigation between headings?

Perhaps I can play around with a screen reader to grasp what you're saying. I'm willing to help write something up if you point me in the right direction. Equally happy to leave this and work on other stuff that suits my level/knowledge 😃

@ericwbailey
Copy link
Member

I don't see a difference, because a skip link goes to wherever you define it right? (Other than the announcement maybe) Are you referring to general navigation between landmarks vs navigation between headings?

Most screen readers will read what they are focused on with default settings, so if it is a container it will be all the container's contents. If it's a heading, it will just be the heading's string. There's circumstances where you'd want to use either approach, so I don't think there's a hard and fast rule over what is objectively better for all situations.

I think if experimenting with a screen reader is something you'd be interested in doing to test this that it'd be a great start! NVDA is free, runs on Windows, and is relatively easy to get started using. A reduced test case CodePen would also be a great way to check out the behavior for yourself.

Happy to let you update the post you want, or we could also do it. Whichever you prefer!

@WW3
Copy link

WW3 commented Mar 2, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
article audit good first issue A small, good place to get started working with the site. post Article submissions and edits.
Projects
None yet
Development

No branches or pull requests

4 participants