New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use previewMint + mint in setUpVault #5

Open

frangio opened this issue Nov 23, 2022 · 0 comments

frangio commented Nov 23, 2022

erc4626-tests/ERC4626.test.sol

Lines 36 to 39 in 8b1d7c2

    
           uint shares = init.share[i]; 
        
           try IMockERC20(_underlying_).mint(user, shares) {} catch { vm.assume(false); } 
        
           _approve(_underlying_, user, _vault_, shares); 
        
           vm.prank(user); try IERC4626(_vault_).deposit(shares, user) {} catch { vm.assume(false); }

The tests are assuming the vault starts at 1:1 price. The following would be more general:

uint shares = init.share[i];
uint assets = IERC4626(_vault_).previewMint(shares);
try IMockERC20(_underlying_).mint(user, assets) {} catch { vm.assume(false); } 
_approve(_underlying_, user, _vault_, assets); 
vm.prank(user); try IERC4626(_vault_).mint(shares, user) {} catch { vm.assume(false); }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment