Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Standardization of responses according to eth_rpc specs for eth_ methods related to byNumber and byHash #234

Open
phklive opened this issue Apr 22, 2023 · 1 comment

Comments

@phklive
Copy link

phklive commented Apr 22, 2023

The methods:
eth_getBlockByNumber
eth_getBlockTransactionCountByNumber
eth_getBlockByHash
eth_getBlockTransactionCountByHash

Some respond with null and some respond with an error if passed a block that has not been synced by helios.

But in the eth_specs we can see that the normal behavior in that case should always be returning null.

The idea is to standardize the responses of these methods to make them always repsond with null in case an unsynced block is passed.

It could also be a good idea to add a print / log "block has not been synced by helios client" or something following those lines.

@phklive phklive changed the title Feat: Standardization of responses according to eth_rpc specs for eth_ methods related to byNumber and byHash feat: Standardization of responses according to eth_rpc specs for eth_ methods related to byNumber and byHash Apr 22, 2023
@giovannivignone
Copy link
Contributor

@phklive Thanks for calling this out. I will get this implemented

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants