You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The methods:
eth_getBlockByNumber
eth_getBlockTransactionCountByNumber
eth_getBlockByHash
eth_getBlockTransactionCountByHash
Some respond with null and some respond with an error if passed a block that has not been synced by helios.
But in the eth_specs we can see that the normal behavior in that case should always be returning null.
The idea is to standardize the responses of these methods to make them always repsond with null in case an unsynced block is passed.
It could also be a good idea to add a print / log "block has not been synced by helios client" or something following those lines.
The text was updated successfully, but these errors were encountered:
phklive
changed the title
Feat: Standardization of responses according to eth_rpc specs for eth_ methods related to byNumber and byHash
feat: Standardization of responses according to eth_rpc specs for eth_ methods related to byNumber and byHash
Apr 22, 2023
The methods:
eth_getBlockByNumber
eth_getBlockTransactionCountByNumber
eth_getBlockByHash
eth_getBlockTransactionCountByHash
Some respond with null and some respond with an error if passed a block that has not been synced by helios.
But in the eth_specs we can see that the normal behavior in that case should always be returning null.
The idea is to standardize the responses of these methods to make them always repsond with null in case an unsynced block is passed.
It could also be a good idea to add a print / log "block has not been synced by helios client" or something following those lines.
The text was updated successfully, but these errors were encountered: