Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash on rpc error(s) #323

Open
Shungy opened this issue Feb 11, 2024 · 1 comment
Open

Crash on rpc error(s) #323

Shungy opened this issue Feb 11, 2024 · 1 comment

Comments

@Shungy
Copy link

Shungy commented Feb 11, 2024

Should probably gracefully handle this:

thread 'tokio-runtime-worker' panicked at /home/runner/work/helios/helios/execution/src/evm.rs:76:47:
called `Result::unwrap()` on an `Err` value: rpc error on method: get_proof, message: Deserialization Error: invalid type: string "too many requests, we recommend you to use free api key", expected struct JsonRpcError at line 1 column 67. Response: {"error": "too many requests, we recommend you to use free api key","id":39, "project": "11307768e6d77951256a33cc9abd40851f6f5ce8"}

Location:
    execution/src/rpc/http_rpc.rs:54:30
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
Aborted (core dumped)
@ncitron
Copy link
Collaborator

ncitron commented Feb 12, 2024

Ah yeah that is a good idea. We do handle retries right now via ethers but it seems depending on what type of RPC provider you are using it may fail. We should add a fallback retry in case ethers retries blows up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants