Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rename optimism to op-mainnet #421

Open
ncitron opened this issue Nov 2, 2024 · 1 comment · May be fixed by #422
Open

chore: rename optimism to op-mainnet #421

ncitron opened this issue Nov 2, 2024 · 1 comment · May be fixed by #422
Labels
good first issue Good for newcomers opstack OP Stack related work

Comments

@ncitron
Copy link
Collaborator

ncitron commented Nov 2, 2024

Optimism has been renamed to OP Mainnet. We should change all references to optimism to op-mainnet to reflect this.

@ncitron ncitron added opstack OP Stack related work good first issue Good for newcomers labels Nov 2, 2024
@MuhtasimTanmoy MuhtasimTanmoy linked a pull request Nov 2, 2024 that will close this issue
@MuhtasimTanmoy
Copy link

Which occurrence of optimism is within the scope of of renaming?

  • No endpoints are affected right?
README.md

[op-mainnet]
consensus_rpc = "https://optimism.operationsolarstorm.org"
execution_rpc = "https://opt-mainnet.g.alchemy.com/v2/XXXXX"
opstack/src/server/net/block_handler.rs

blocks_v3_topic: IdentTopic::new(format!("/optimism/{}/2/blocks", chain_id)) 
  • Does DOM elements id has any other reference? or should be renamed?
helios-ts/index.html

<div class="panel" id="optimism-panel">
....
<div class="blocks" id="optimism-blocks">
...
<pre class="block-info syncing" id="optimism-syncing">Syncing...</pre>

Other than that, does #422 looks sufficient?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers opstack OP Stack related work
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants