Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Transform overloads for all transformation data types #57

Open
luithefirst opened this issue Apr 8, 2021 · 1 comment
Open

Add Transform overloads for all transformation data types #57

luithefirst opened this issue Apr 8, 2021 · 1 comment

Comments

@luithefirst
Copy link
Member

luithefirst commented Apr 8, 2021

We have various types that have a .Transform or .Transformed method (e.g. Box3d, Plane3d, Hull3d, Polygon3d, ...). In most cases, there is only an overload for Trafo3d. We should complete this and make sure there are overloads for Trafo3d, M44d, Similarity3d, Rigid3d, Euclidean3d and review the same for 2d data types.

We might also want to consider adding .InvTransform/InvTransformed methods. This might have a slightly better performance compared to passing the inverted versions of the transform types. This should be evaluated first.

@hyazinthh
Copy link
Member

I've added more transformation methods for Polygon2d or Polygon3d. There are now in-place and inverse variants. The latter seem to be a bit more efficient than computing the inverse transformation first. I'm not sure yet if all of these variants make sense for other types. E.g. do you really need to be able to transform a Box2d in place?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants