Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging control? #105

Closed
DoumanAsh opened this issue Dec 11, 2017 · 3 comments
Closed

Logging control? #105

DoumanAsh opened this issue Dec 11, 2017 · 3 comments
Assignees

Comments

@DoumanAsh
Copy link
Contributor

DoumanAsh commented Dec 11, 2017

There are seems to be some println inside of code.
Do you think there should be control over it?

@aatxe aatxe self-assigned this Dec 11, 2017
@aatxe
Copy link
Owner

aatxe commented Dec 11, 2017

I agree that we should use logging (via log crate, most likely), and eliminate any printlns. Did you actually encounter any output though? A cursory search seems to turn up only one println that is not inside of a test case, and that would appear only once in a program (and only if they add their own certificate for SSL).

In general, I tried to avoid making the library noisy (with the understanding that there is no logging framework). There is probably places where it would be nice to log info (especially when #88 is done).

@DoumanAsh
Copy link
Contributor Author

@aatxe Yeah sorry, at first look I thought there are several printlns, but then I examined in details and too found only one rare println on adding certificate path.

To me of course silent irc is better than anything else :)

@aatxe
Copy link
Owner

aatxe commented Dec 12, 2017

This is fixed in 7625c36. Cheers! 🍻

@aatxe aatxe closed this as completed Dec 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants