fix(airbyte-ci): fix progressive rollout finalize steps bugs (airbytehq#46278)

Co-authored-by: Octavia Squidington III <[email protected]>

Author: natikgadzhi

.github/workflows/finalize_rollout.yml

@@ -43,6 +43,7 @@ jobs:
           metadata_service_gcs_credentials: ${{ secrets.METADATA_SERVICE_PROD_GCS_CREDENTIALS }}
           sentry_dsn: ${{ secrets.SENTRY_AIRBYTE_CI_DSN }}
           slack_webhook_url: ${{ secrets.PUBLISH_ON_MERGE_SLACK_WEBHOOK }}
+          spec_cache_gcs_credentials: ${{ secrets.SPEC_CACHE_SERVICE_ACCOUNT_KEY_PUBLISH }}
           subcommand: "connectors --name=${{ github.event.inputs.connector_name }} publish --promote-release-candidate"
       - name: Rollback {{ github.event.inputs.connector_name }} release candidate
         id: rollback-release-candidate

airbyte-ci/connectors/pipelines/README.md

@@ -851,7 +851,8 @@ airbyte-ci connectors --language=low-code migrate-to-manifest-only
 
 | Version | PR                                                         | Description                                                                                                                  |
 | ------- | ---------------------------------------------------------- | ---------------------------------------------------------------------------------------------------------------------------- |
-| 4.36.1  |  | `airbyte-ci format js` respects `.prettierc` and `.prettierignore`                                                           |
+| 4.36.2  | [#46278](https://github.com/airbytehq/airbyte/pull/46278)  | Fixed a bug in RC rollout and promote not taking `semaphore`                                                                 |
+| 4.36.1  | [#46274](https://github.com/airbytehq/airbyte/pull/46274)  | `airbyte-ci format js` respects `.prettierc` and `.prettierignore`                                                           |
 | 4.36.0  | [#44877](https://github.com/airbytehq/airbyte/pull/44877)  | Implement `--promote/rollback-release-candidate` in `connectors publish`.                                                    |
 | 4.35.6  | [#45632](https://github.com/airbytehq/airbyte/pull/45632)  | Add entry to format file ignore list (`destination-*/expected-spec.json`)                                                    |
 | 4.35.5  | [#45672](https://github.com/airbytehq/airbyte/pull/45672)  | Fix docs mount during publish                                                                                                |

airbyte-ci/connectors/pipelines/pipelines/airbyte_ci/connectors/publish/pipeline.py

@@ -543,7 +543,7 @@ async def _run_python_registry_publish_pipeline(context: PublishConnectorContext
     return results, False
 
 
-async def run_connector_rollback_pipeline(context: PublishConnectorContext) -> ConnectorReport:
+async def run_connector_rollback_pipeline(context: PublishConnectorContext, semaphore: anyio.Semaphore) -> ConnectorReport:
     """Run a rollback pipeline for a single connector.
 
     1. Check if the current metadata is a release candidate
@@ -554,19 +554,22 @@ async def run_connector_rollback_pipeline(context: PublishConnectorContext) -> C
     """
 
     results = []
-    async with context:
-        assert context.rollout_mode == RolloutMode.ROLLBACK, "This pipeline can only run in rollback mode."
-        assert context.connector.metadata.get("releases", {}).get(
-            "isReleaseCandidate", True
-        ), "This pipeline can only run for release candidates."
-        results.append(
-            await MetadataRollbackReleaseCandidate(context, context.metadata_bucket_name, context.metadata_service_gcs_credentials).run()
-        )
+    async with semaphore:
+        async with context:
+            assert context.rollout_mode == RolloutMode.ROLLBACK, "This pipeline can only run in rollback mode."
+            assert context.connector.metadata.get("releases", {}).get(
+                "isReleaseCandidate", True
+            ), "This pipeline can only run for release candidates."
+            results.append(
+                await MetadataRollbackReleaseCandidate(
+                    context, context.metadata_bucket_name, context.metadata_service_gcs_credentials
+                ).run()
+            )
 
     return ConnectorReport(context, results, name="ROLLBACK RESULTS")
 
 
-async def run_connector_promote_pipeline(context: PublishConnectorContext) -> ConnectorReport:
+async def run_connector_promote_pipeline(context: PublishConnectorContext, semaphore: anyio.Semaphore) -> ConnectorReport:
     """Run a promote pipeline for a single connector.
 
     1. Publish the release candidate version docker image with the latest tag.
@@ -576,19 +579,20 @@ async def run_connector_promote_pipeline(context: PublishConnectorContext) -> Co
         ConnectorReport: The reports holding promote results.
     """
     results = []
-    async with context:
-        assert context.rollout_mode == RolloutMode.PROMOTE, "This pipeline can only run in promote mode."
-        assert context.connector.metadata.get("releases", {}).get(
-            "isReleaseCandidate", True
-        ), "This pipeline can only run for release candidates."
-        metadata_promote_result = await MetadataPromoteReleaseCandidate(
-            context, context.metadata_bucket_name, context.metadata_service_gcs_credentials
-        ).run()
-        results.append(metadata_promote_result)
-        if metadata_promote_result.status is StepStatus.FAILURE:
-            return ConnectorReport(context, results, name="PROMOTE RESULTS")
-        publish_latest_tag_results = await PushVersionImageAsLatest(context).run()
-        results.append(publish_latest_tag_results)
+    async with semaphore:
+        async with context:
+            assert context.rollout_mode == RolloutMode.PROMOTE, "This pipeline can only run in promote mode."
+            assert context.connector.metadata.get("releases", {}).get(
+                "isReleaseCandidate", True
+            ), "This pipeline can only run for release candidates."
+            metadata_promote_result = await MetadataPromoteReleaseCandidate(
+                context, context.metadata_bucket_name, context.metadata_service_gcs_credentials
+            ).run()
+            results.append(metadata_promote_result)
+            if metadata_promote_result.status is StepStatus.FAILURE:
+                return ConnectorReport(context, results, name="PROMOTE RESULTS")
+            publish_latest_tag_results = await PushVersionImageAsLatest(context).run()
+            results.append(publish_latest_tag_results)
     return ConnectorReport(context, results, name="PROMOTE RESULTS")
 
 

airbyte-ci/connectors/pipelines/pyproject.toml

@@ -4,7 +4,7 @@ build-backend = "poetry.core.masonry.api"
 
 [tool.poetry]
 name = "pipelines"
-version = "4.36.1"
+version = "4.36.2"
 description = "Packaged maintained by the connector operations team to perform CI for connectors' pipelines"
 authors = ["Airbyte <[email protected]>"]