Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No crotmp Syntax Highlighting #25

Closed
librasteve opened this issue Nov 20, 2024 · 3 comments
Closed

No crotmp Syntax Highlighting #25

librasteve opened this issue Nov 20, 2024 · 3 comments
Labels
regression A regression
Milestone

Comments

@librasteve
Copy link

When opening a .crotmp file there is no syntax highlighting.

Under CMD+, (open setting) > Editor > File Types there is no entry under Cro::HTTP::WebApp template

This is a regression vs. final Comma Complete and maybe a regression against recent comma-plugin iterations.

All the raku file types are working fine.

Expected:
Screenshot 2024-11-20 at 17 46 14

Got:
Screenshot 2024-11-20 at 17 54 07

@ab5tract ab5tract added the regression A regression label Nov 21, 2024
@ab5tract ab5tract added this to the 2.0 Release milestone Nov 21, 2024
@ab5tract
Copy link
Owner

ab5tract commented Nov 21, 2024

This is expected in comma-plugin as I have avoided everything related to Cro.1

Please see #21. Feel free to add any other remaining missing Cro-related functionalities to the checklist in that ticket.

Footnotes

  1. EDIT: This narrowing of scope has been helpful so far but I also feel that the time has come to re-introduce Cro stuffs.

@ab5tract ab5tract moved this to Todo in Cro Nov 21, 2024
@ab5tract ab5tract added this to Cro Nov 21, 2024
@ab5tract
Copy link
Owner

@librasteve This should be addressed in beta 31

@librasteve
Copy link
Author

oh - I see that explains it - I'll close this issue for now

I'm hoping to add Fragment highlighting (a new Cro::WebApp::Template feature)

@github-project-automation github-project-automation bot moved this from In Progress to Done in Cro Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
regression A regression
Projects
Status: Done
Development

No branches or pull requests

2 participants