Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When non-url params don't match, don't send a 404 #55

Open
mlms13 opened this issue Mar 19, 2015 · 0 comments
Open

When non-url params don't match, don't send a 404 #55

mlms13 opened this issue Mar 19, 2015 · 0 comments

Comments

@mlms13
Copy link
Contributor

mlms13 commented Mar 19, 2015

Right now when params don't match, we're falling through to the next route handler (and eventually sending a 404 if nothing "matches"). This is a reasonable thing to do for non-matching URL params (e.g. an Int :id when we're expecting a String).

However, it's arguably a bit strange to send a 404 when you POST some params in the body, but you're missing a required param. The route isn't actually 404, it's just a 400 bad request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant