Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Less opinionated and simpler minimal config #355

Closed
2 tasks done
Tracked by #353
gdalle opened this issue Jul 13, 2024 · 6 comments
Closed
2 tasks done
Tracked by #353

Less opinionated and simpler minimal config #355

gdalle opened this issue Jul 13, 2024 · 6 comments

Comments

@gdalle
Copy link

gdalle commented Jul 13, 2024

Description

Edit: Moved the list here so it works

Here are a few changes I'd like to see in the default config before we (re-)generate FixMe.jl:

For docs:

For the rest:

  • Leave JuliaFormatter.toml empty or pick a generic style guide (style="blue" is a good choice) instead of individual custom options
  • Leave .editorconfig empty
  • Isn't CODECOV_TOKEN supposed to be in uppercase?

Ping @abelsiqueira and @CasBex

@abelsiqueira
Copy link
Collaborator

abelsiqueira commented Jul 13, 2024

Cleaning the previews is already an issue, just linked it. The rest of the docs comments seem good. Let's see how they render with the changes.

Why the .editorconfig empty? It's mostly a no-op. Is there a specific line that you want removed?

CODECOV_TOKEN is uppercase, but ReusableWorkflows uses the passed secret from Test and TestOnPRs (it's uppercase there. ReusableWorkflows can't use CODECOV_TOKEN directly. I named it as an argument (snake_case).

@CasBex, let me know if you want to work on any of these issues.

@CasBex
Copy link

CasBex commented Jul 13, 2024

I'm not too familiar with all the CI stuff so I'm not really the right person for this I think.

@abelsiqueira
Copy link
Collaborator

No prob, I'll update it.

@abelsiqueira
Copy link
Collaborator

Some comments, discussed with @gdalle:

  • I left the repo keyword because it's used in the tests and needed if you don't have a GH repo yet.
  • I left some basic formatting in JuliaFormatter, but no strong opinions. editorconfig is kept for the same reason.

I am releasing 0.9.0 right now with these changes.

@abelsiqueira
Copy link
Collaborator

@allcontributors please add @gdalle for ideas

@abelsiqueira
Copy link
Collaborator

Some of these were discussed in person at the JuliaCon 2024 Hackathon and some were implemented. I'll close, but feel free to open with comments on what it missing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants