Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spec files loading from their own file. #28

Open
lightsofapollo opened this issue Oct 10, 2011 · 3 comments
Open

Spec files loading from their own file. #28

lightsofapollo opened this issue Oct 10, 2011 · 3 comments
Labels

Comments

@lightsofapollo
Copy link

Hi All,

When debugging one of the first things I noticed is the backtraces seem to lead nowhere because the specs are included directly in the HTML file for the view. I made a quick hack to load them from their own file (using Sinatra + File.read) and it seems to work fine and give me correct backtraces.

Is there a reason for not including these files vs embedding them? I can easily submit a patch if you like.
I will probably commit this in a fork sometime today or tomorrow for my team to use either way.

Thank You,
James Lal

@jnicklas
Copy link
Collaborator

The original reason for doing this was that the specs silently passed if an error occurred while processing the specs. I guess though that wouldn't be a problem now, since we're rescuing errors and making them into failing specs anyway. We might want to do the same thing with 404's however.

@lightsofapollo
Copy link
Author

Great, I will write up a patch in the next few days. I have been (personally) using evergreen for the last 6 months now and I love it. The big difference it made however was getting the whole team up and running in less then an hour with a great test runner and selenium integration.

I hope to be able to contribute back something helpful.

@abepetrillo
Copy link
Owner

@lightsofapollo Did you ever get around to doing a patch? If not I might invest some time in this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants