Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Matching Rules for 'Generic Text Detector' #83

Open
abertschi opened this issue Aug 15, 2022 · 13 comments
Open

Matching Rules for 'Generic Text Detector' #83

abertschi opened this issue Aug 15, 2022 · 13 comments

Comments

@abertschi
Copy link
Owner

No description provided.

@famewolf
Copy link

Can you provide an example from one of the supported services to use as a model or allow use to view the keyword search for the supported services in the app?

@abertschi
Copy link
Owner Author

Can you provide an example from one of the supported services to use as a model or allow use to view the keyword search for the supported services in the app?

https://abertschi.github.io/ad-free/troubleshooting/troubleshooting.html#generic-text-detector

@famewolf
Copy link

Ok...I wondered because accuradio is still giving it's tiny " always free" ads..so I added "com.slipstream.accuradio" and "will resume" to the general ad section.

@abertschi
Copy link
Owner Author

Ok...I wondered because accuradio is still giving it's tiny " always free" ads..so I added "com.slipstream.accuradio" and "will resume" to the general ad section.

Do you happen to have it granted unnecessary permission such as microphone? I know of a case that got resolved once we removed all permissions from accuradio.

@famewolf
Copy link

The only permission it had was for "nearby devices". It ignored my general filter even after I watched and changed it to "Music will resume shortly" which is exact message displayed during their 5 second or less "accuradio is free and always will be" ads.

@abertschi
Copy link
Owner Author

The only permission it had was for "nearby devices". It ignored my general filter even after I watched and changed it to "Music will resume shortly" which is exact message displayed during their 5 second or less "accuradio is free and always will be" ads.

Seems that the issue is device specific. the general filter will likely not work in this app as they build a custom widget to draw content on the notification. Consider creating a recording dump as described here https://abertschi.github.io/ad-free/troubleshooting/troubleshooting.html#org4d393d1 with Accuradio tracer and submit the dump.

@famewolf
Copy link

famewolf commented Oct 11, 2022 via email

@unseenlarks
Copy link

unseenlarks commented Nov 21, 2023

i've been having this same issue on a moto g32, running Android 12. checked for unnecessary permissions, and used the generic text detector filter, just like famewolf.
the Accuradio tracer generated this file.
adfree-accuradio.txt

edit: tested what happened when 'best effort detector', which i'd forgotten about, was enabled. these 'music will resume shortly' ads still get through.

@abertschi
Copy link
Owner Author

i've been having this same issue on a moto g32, running Android 12. checked for unnecessary permissions, and used the generic text detector filter, just like famewolf.
the Accuradio tracer generated this file.
adfree-accuradio.txt

Thank you for the dump, with the dump we can easily add a rule for this case. Will do it next time I find the time to release a new update 👍 .

@unseenlarks
Copy link

thank you very much!

@unseenlarks
Copy link

unseenlarks commented Dec 11, 2023

hello again. sadly i don't see any changes on v3.2. i have added a generic text detector again for com.slipstream.accuradio / as "music will resume shortly", and the app has been granted the permissions it asks for. do i need to try anything else, in case this is user error? thank you.

another thing, it doesn't show a notification even if 'always-on notification is enabled'. the app does work, as tapping the music note on the second screen mutes audio, and fires the 'ad detected' notification.

the device now runs Android 13, so i had to enable permissions (allow 'restricted settings'), so i could fully grant them to the app.

also i use the device in dark mode and the smaller notifications the app gives (for example when enabling developer mode, then a tracer for a specific app), are hard to read.

adfree-accuradio.txt

@abertschi
Copy link
Owner Author

hello again. sadly i don't see any changes on v3.2. i have added a generic text detector again for com.slipstream.accuradio / as "music will resume shortly", and the app has been granted the permissions it asks for. do i need to try anything else, in case this is user error? thank you.

another thing, it doesn't show a notification even if 'always-on notification is enabled'. the app does work, as tapping the music note on the second screen mutes audio, and fires the 'ad detected' notification.

the device now runs Android 13, so i had to enable permissions (allow 'restricted settings'), so i could fully grant them to the app.

also i use the device in dark mode and the smaller notifications the app gives (for example when enabling developer mode, then a tracer for a specific app), are hard to read.

adfree-accuradio.txt

@unseenlarks Thanks for the new recording.
Let's move this conversation to here: #93

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants
@abertschi @famewolf @unseenlarks and others