Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to a more comprehensive glob matcher #1

Open
abhilash1in opened this issue May 6, 2020 · 0 comments
Open

Switch to a more comprehensive glob matcher #1

abhilash1in opened this issue May 6, 2020 · 0 comments
Assignees
@abhilash1in
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@abhilash1in
Copy link
Owner

The existing glob matcher is very primitive and works only with *:
https://github.com/action-factory/aws-secrets-manager-action/blob/276968b04438660afff72bad5f5725f3af9fea95/src/utils.ts#L50-L52

Use something like isaacs/minimatch instead, as it offers more matching features.
@abhilash1in abhilash1in added the enhancement New feature or request label May 6, 2020
@abhilash1in abhilash1in self-assigned this May 6, 2020
@abhilash1in abhilash1in added good first issue Good for newcomers help wanted Extra attention is needed labels Nov 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abhilash1in abhilash1in

Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@abhilash1in