Migrate to using Swift concurrency #613
Labels
code-quality
Affects the developer experience when working in our codebase.
Comments
lawrence-forooghian
added
the
code-quality
|
➤ Automation for Jira commented: The link to the corresponding Jira issue is https://ably.atlassian.net/browse/SDK-3450 |
lawrence-forooghian
added a commit
that referenced
this issue
Mar 13, 2023
Resolves #597. Our README currently says that our minimum iOS version is 12 and above, and during the development of this SDK we have been working with this requirement in mind – for example by not using Swift concurrency, which is only available in iOS 13 and above. Our Package.swift was however updated in eeb88b0 to require iOS 13 and above, without any explanation for this change. To clear up this confusion, we have now spoken to clients to understand their iOS version requirements, and have found out that we can target iOS 13 for the subscriber SDK and iOS 14 for the publisher SDK. For now, since there are no obvious features of the iOS 14 SDK that we need, I’ll keep a deployment target of iOS 13 for both SDKs, but we may wish to decouple them in the future so that they can have separate deployment targets. See #613 for taking advantage of the now-available Swift concurrency features. Internal threads re client requirements: 1. https://ably-real-time.slack.com/archives/C01EPJENRD0/p1677611526684719 2. https://ably-real-time.slack.com/archives/C01EPJENRD0/p1678698762445489
lawrence-forooghian
added a commit
that referenced
this issue
Mar 13, 2023
Resolves #597. Our README currently says that our minimum iOS version is 12 and above, and during the development of this SDK we have been working with this requirement in mind – for example by not using Swift concurrency, which is only available in iOS 13 and above. Our Package.swift was however updated in eeb88b0 to require iOS 13 and above, without any explanation for this change. To clear up this confusion, we have now spoken to clients to understand their iOS version requirements, and have found out that we can target iOS 13 for the subscriber SDK and iOS 14 for the publisher SDK. For now, since there are no obvious features of the iOS 14 SDK that we need, I’ll keep a deployment target of iOS 13 for both SDKs, but we may wish to decouple them in the future so that they can have separate deployment targets. See #613 for taking advantage of the now-available Swift concurrency features. Internal threads re client requirements: 1. https://ably-real-time.slack.com/archives/C01EPJENRD0/p1677611526684719 2. https://ably-real-time.slack.com/archives/C01EPJENRD0/p1678698762445489
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Now that we've confirmed a deployment target of iOS 13 (#597), we can start using Swift concurrency. As well as
async/awaitand structured concurrency, this also allows us to useAsyncSequence, which we may wish to start using as a way of achieving parity with Android’s use of Kotlin streams.We can start using these features internally immediately, and may wish to refactor existing internal code to use it. We should also consider migrating the public API to use them.
This issue serves to remind us of this opportunity, and we can split it out into separate more detailed tickets as we wish.
The text was updated successfully, but these errors were encountered: