Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Push#requestPermission Method to Support Both iOS and Android #545

Open
ttypic opened this issue Sep 18, 2024 · 0 comments
Open
Labels
enhancement New feature or improved functionality.

Comments

@ttypic
Copy link
Contributor

ttypic commented Sep 18, 2024

The current Push#requestPermission method has several major issues:

  1. It only works for iOS and lacks support for Android.
  2. It requires the Ably client to be initialized, which is not ideal for a simple permission request.
  3. The API doesn’t support retrieving information if permission is permanently denied, or showing the permission rationale widget flag

Proposed Solution:

  • Move the requestPermission method out of the Push object and into a separate PushUtils class as a static method.
  • Implement cross-platform support for both iOS and Android, ensuring permission requests can be handled universally without needing to initialize the Ably client.

┆Issue is synchronized with this Jira Story by Unito

@ttypic ttypic added the enhancement New feature or improved functionality. label Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or improved functionality.
Development

No branches or pull requests

1 participant