Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement missing RTP2f #636

Open
sacOO7 opened this issue Mar 25, 2024 · 1 comment · May be fixed by #637
Open

Implement missing RTP2f #636

sacOO7 opened this issue Mar 25, 2024 · 1 comment · May be fixed by #637

Comments

@sacOO7
Copy link
Collaborator

sacOO7 commented Mar 25, 2024

┆Issue is synchronized with this Jira Task by Unito

@sacOO7 sacOO7 linked a pull request Mar 26, 2024 that will close this issue
@sacOO7
Copy link
Collaborator Author

sacOO7 commented May 31, 2024

Presence queue was added as a part of the commit c41ddeb. This means there is no need to maintain channel queue as per spec. It can be completely removed altogether. This has been identified while working on ably-ruby. See comment -> ably/ably-ruby#407 (comment)

Note - As per

func (c *RealtimeChannel) onConnStateChange(change ConnectionStateChange) {
, for both ConnectionStateConnected and ConnectionStateFailed, we need to flush and fail the presence queue as well.
We used to do it before this commit was added. Currently, we only do it when channel is detached, failed or suspended. Also, need to check if this is really needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

1 participant