Rest host fallback #147
Merged
Rest host fallback #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
sacOO7
commented
Apr 9, 2022
•
sacOO7
commented
- Fixed Implement remembering fallback host during failures #107
- Fixed Add support for RSC15e, d, f (Host Fallback ) #111
- Fixed Write spec tests for RSC15e, d, f (Host Fallback ) #124
- Fixed Fallback not being used with SSL timeouts #85
…ckHosts" This reverts commit a3093df.
owenpearson
requested changes
Apr 21, 2022
There was a problem hiding this comment.
Looks good on the whole. I've left a few minor comments to address.
btw, I would have preferred for the move of API_VERSION/LIB_VERSION to Defaults to be in a separate PR as all the diffs from that made this one more difficult to review. Same goes for moving systemTime to Miscellaneous.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.