Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Anchor links embed language - is this intentional? #1928

Open
mattheworiordan opened this issue Jun 17, 2023 · 0 comments
Open

Anchor links embed language - is this intentional? #1928

mattheworiordan opened this issue Jun 17, 2023 · 0 comments
Labels
bug A broken link, image etc

Comments

@mattheworiordan
Copy link
Member

mattheworiordan commented Jun 17, 2023

If you're in the docs and click on the chain icon that appears when rolling over a heading, it generates a deep link to that page and that section. See screenshot below for an example:

MO screenshot 2023-06-17 at 12 01 39

The link includes the language though, such as https://ably.com/docs/realtime/channels?lang=javascript#channel-states. I am not sure that's the best behaviour, but probably one to discuss the pros and cons. Including the language link means everyone will always be taken to the language preference of the user generating the link, as opposed to the respective docs for their preferred language or default language of Javascript.

Do we think this is the best behaviour?

┆Issue is synchronized with this Jira Task by Unito

@mattheworiordan mattheworiordan added the bug A broken link, image etc label Jun 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A broken link, image etc
Development

No branches or pull requests

1 participant