Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link to GitHub comment in SDK coding standards doesn’t work #6

Open
lawrence-forooghian opened this issue Jan 4, 2022 · 1 comment
Labels
SDK Relates to the Ably SDK Team and our ways of working in open source.

Comments

@lawrence-forooghian
Copy link
Collaborator

lawrence-forooghian commented Jan 4, 2022

This link points to a PR comment which has already been resolved. When following this link, the browser just leaves you at the top of the PR page without any indication of which was the linked comment.

@QuintinWillison
Copy link
Contributor

@lawrence-forooghian That is annoying. I've had a quick play around and I'm not sure I can find a workaround. Once a conversation has been closed, perhaps only when it's in a bigger and/or closed PR, it seems the comment deep links stop working (presumably because not all the page DOM elements get created immediately, therefore no id exists to link to 🤷).

Thus, unless there's a mechanism GitHub offer that I'm unaware of to realistically link to old comments, then this is unworkable and the fix for this issue is to simply remove this 'dead' link.

@QuintinWillison QuintinWillison added the SDK Relates to the Ably SDK Team and our ways of working in open source. label Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
SDK Relates to the Ably SDK Team and our ways of working in open source.
Development

No branches or pull requests

2 participants