Updated the spec so that it reflects the behaviour implemented in ably-cocoa PR #1847 #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
textile/features.textile
Outdated
| @@ -1207,7 +1207,7 @@ h3(#activation-state-machine). Activation State Machine | |||
| *** @(RSH3g1)@ On event @CalledDeactivate@: | |||
| **** @(RSH3g1a)@ Transitions to @WaitingForDeregistration@. | |||
| *** @(RSH3g2)@ On event @Deregistered@: | |||
| **** @(RSH3g2a)@ Clears all local @DeviceDetails@. | |||
| **** @(RSH3g2a)@ Generates a new pair of device @id@ and @deviceSecret@ as described in "RSH3a2b":#RSH3a2b. Clears all other local @DeviceDetails@. | |||
There was a problem hiding this comment.
This only partially describes the ably-cocoa behaviour, doesn't it? In ably-cocoa, id and deviceSecret generation are completely decoupled from the CalledActivate event, meaning that RSH3a2b and RSH8b would also need to be changed if we wished for the spec to describe the behaviour of ably-cocoa.
Also, same point as #182 (comment) re spec point modification.
|
I'm not really familiar with the context here or the push activation state machine implemented in sdks, so going to untag myself and suggest @owenpearson instead |
SimonWoolf
requested review from
owenpearson
and removed request for
SimonWoolf
…y/ably-cocoa#1847, where a new device ID is generated as soon as the previous ones are cleared, so that id is never null.
maratal
force-pushed
the
PCD2-RSH3g2a-never-nil-fix
branch
from
cd432e1
to
e99fb27
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the spec so that it reflects the behaviour implemented in ably/ably-cocoa#1847, where a new device ID is generated as soon as the previous ones are cleared, so that id is never null.
Originally posted by @lawrence-forooghian here
Closes #180