Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Empty directory displays file icon #542

Closed
mjherzog opened this issue Nov 8, 2022 · 3 comments · Fixed by #604
Closed

Empty directory displays file icon #542

mjherzog opened this issue Nov 8, 2022 · 3 comments · Fixed by #604
Labels
bug ui version4 Issue for v4

Comments

@mjherzog
Copy link
Member

mjherzog commented Nov 8, 2022

Description

In the Table View, empty directories display a file icon instead of a directory icon.

System configuration

For bug reports, it really helps us to know:

  • OS = Windows
  • SCWB v4.0beta
  • SCTK v31.1.1
@OmkarPh
Copy link
Collaborator

OmkarPh commented Mar 31, 2023

In the library, I couldn't find a way to explicitly specify if a node is file or directory, it just decides it on basis of whether it has children or not
I've asked about it here react-component/tree#736

@mjherzog
Copy link
Member Author

Good to know why. Lets hope they want to fix it.

@mjherzog mjherzog added the version4 Issue for v4 label Apr 4, 2023
@OmkarPh OmkarPh mentioned this issue Oct 2, 2023
Merged
@OmkarPh OmkarPh linked a pull request Oct 2, 2023 that will close this issue
Fixed Empty directory being shown with file icon #604
Merged
@OmkarPh
Copy link
Collaborator

OmkarPh commented Oct 2, 2023

They've added a isLeaf API option to fix this
This fixes the issue, For future reference, sample scan - withEmptyDir.json.txt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug ui version4 Issue for v4
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed Empty directory being shown with file icon aboutcode-org/scancode-workbench
2 participants
@mjherzog @OmkarPh