Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dapr integration improvements #14024

Closed
2 tasks done
hikalkan opened this issue Sep 15, 2022 · 5 comments · Fixed by #14164
Closed
2 tasks done

Dapr integration improvements #14024

hikalkan opened this issue Sep 15, 2022 · 5 comments · Fixed by #14164

Comments

@hikalkan
Copy link
Member

hikalkan commented Sep 15, 2022

Wait for #14015

@maliming
Copy link
Member

use the standard [Topic(...)] attribute

I can't refer to DaprEndpointRouteBuilderExtensions class, they use some internal classes.

I will open a PR in dapr/dotnet-sdk. If they accept it will be easy to implement.

@maliming maliming added the stuck label Sep 28, 2022
@maliming
Copy link
Member

dapr/dotnet-sdk#961

@hikalkan
Copy link
Member Author

@maliming we may consider to implement this ourselves. You can inspire from the original code..

@maliming
Copy link
Member

The original code is too complicated, I think it's better to use it instead of copying some code from it.

https://github.com/dapr/dotnet-sdk/blob/master/src/Dapr.AspNetCore/DaprEndpointRouteBuilderExtensions.cs#L65-L163

@hikalkan
Copy link
Member Author

hikalkan commented Nov 2, 2022

To able to use the standard Topic attribute is critical. Please copy that complex code for now, and follow it to discard ours in the next releases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants