We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AbpAspNetCoreMvcDaprEventBusOptions.Contributors
[Topic(...)]
AbpAspNetCoreMvcDaprPubSubController
Topic
IDaprSerializer
Wait for #14015
The text was updated successfully, but these errors were encountered:
use the standard [Topic(...)] attribute
I can't refer to DaprEndpointRouteBuilderExtensions class, they use some internal classes.
I will open a PR in dapr/dotnet-sdk. If they accept it will be easy to implement.
dapr/dotnet-sdk
Sorry, something went wrong.
dapr/dotnet-sdk#961
@maliming we may consider to implement this ourselves. You can inspire from the original code..
The original code is too complicated, I think it's better to use it instead of copying some code from it.
https://github.com/dapr/dotnet-sdk/blob/master/src/Dapr.AspNetCore/DaprEndpointRouteBuilderExtensions.cs#L65-L163
To able to use the standard Topic attribute is critical. Please copy that complex code for now, and follow it to discard ours in the next releases.
maliming
Successfully merging a pull request may close this issue.
AbpAspNetCoreMvcDaprEventBusOptions.Contributors
and allow users to use the standard[Topic(...)]
attribute on their controller actions. You can check the [DaprEndpointRouteBuilderExtensions](https://github.com/dapr/dotnet-sdk/blob/master/src/Dapr.AspNetCore/DaprEndpointRouteBuilderExtensions.cs) class to understand how you can find the routes. Our endpoint (AbpAspNetCoreMvcDaprPubSubController
) should only handle the events those haven't registered with theTopic
attribute.IDaprSerializer
has some unused methods, should we remove them?Wait for #14015
The text was updated successfully, but these errors were encountered: