Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using build metadata in semantic version of a chart causes packager.go to fail #66

Closed
cbullo opened this issue Feb 13, 2024 · 3 comments

Comments

@cbullo
Copy link

cbullo commented Feb 13, 2024

According to Build Metadata it should be possible to use '+' sign to annotate version with build metadata.
However, the regex packager.go:500 doesn't allow that.

Using this string as a chart version will fail: 0.0.9+63-gf336c00.

@abrisco
Copy link
Owner

abrisco commented Feb 13, 2024

Uh-oh. I'd be happy to review a change to fix this 😀

@cbullo
Copy link
Author

cbullo commented Feb 14, 2024

Here's the PR:
67
:)

@abrisco
Copy link
Owner

abrisco commented Aug 14, 2024

This is resolved by #82

@abrisco abrisco closed this as completed Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants