Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve listing and searching requests #2326

Open
dborovcanin opened this issue Jul 3, 2024 · 1 comment
Open

Improve listing and searching requests #2326

dborovcanin opened this issue Jul 3, 2024 · 1 comment
Assignees
@dborovcanin @arvindh123
Labels
enhancement needs-comments question

Comments

@dborovcanin
Copy link
Collaborator 

          We are treating IDs differently, i.e. taking it into account only if other criteria is not there, making `buildQueryConditions` mask the logic of processing IDs. Why?

Originally posted by @dborovcanin in #2305 (comment)
@github-project-automation github-project-automation bot moved this to ⛏ Backlog in Magistrala Jul 3, 2024
@dborovcanin
Copy link
Collaborator Author

We are using the same DTO struct to pass data between search and list functions, and it's becoming too cumbersome because we often don't need all data from the DTO, beating the purpose of the DTO itself.

@dborovcanin dborovcanin mentioned this issue Jul 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dborovcanin dborovcanin

@arvindh123 arvindh123

Labels
enhancement needs-comments question
Projects
Magistrala
Status: ⛏ Backlog
Milestone
No milestone
Development

No branches or pull requests
3 participants
@drasko @dborovcanin @arvindh123