Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider using Protobuf linter #2483

Open
dborovcanin opened this issue Oct 23, 2024 · 1 comment · May be fixed by #2532
Open

Consider using Protobuf linter #2483

dborovcanin opened this issue Oct 23, 2024 · 1 comment · May be fixed by #2532
Assignees

Comments

@dborovcanin
Copy link
Collaborator

dborovcanin commented Oct 23, 2024

@dborovcanin dborovcanin converted this from a draft issue Oct 23, 2024
@dborovcanin dborovcanin self-assigned this Oct 23, 2024
@JeffMboya JeffMboya linked a pull request Nov 15, 2024 that will close this issue
@JeffMboya
Copy link
Contributor

@dborovcanin so I have tried protoc-gen-lint and I get this in the error log:

auth.proto: is a proto3 file that contains optional fields, but code generator protoc-gen-lint hasn't been updated to support optional fields in proto3. Please ask the owner of this code generator to support proto3 optional.

So I switched to protolint which supports optional fields in proto 3. I ahve added it to the CI here: #2532

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ⛏ Backlog
Development

Successfully merging a pull request may close this issue.

2 participants