NOISSUE - Updating Things and Channels Service #9

wambui-pixel · 2024-03-28T17:53:47Z

What does this do?

Updating Things .ts

Which issue(s) does this PR fix/relate to? NOISSUE

Resolves #15 and #17

List any changes that modify/break current functionality

Migrating things.js to things.ts

Have you included tests for your changes?

NO

Did you document any new/modified functionality?

NO

Notes

src/things.ts

src/channels.ts

examples/things.ts

src/users.ts

ianmuchyri · 2024-04-04T11:45:19Z

src/sdk.ts

 import Things from './things'
+// import Groups from "./groups";


remove all the commented out code.

ianmuchyri · 2024-04-04T11:46:49Z

src/defs.ts

@@ -57,9 +55,14 @@ export interface GroupsPage {
 export interface Channel {
  id?: string
  name?: string
+  parent_id?: string
+  credentials?: {


a channel does not have credentials.
Channel struct looks like this:

type Channel struct { ID string `json:"id,omitempty"` DomainID string `json:"domain_id,omitempty"` ParentID string `json:"parent_id,omitempty"` Name string `json:"name,omitempty"` Description string `json:"description,omitempty"` Metadata Metadata `json:"metadata,omitempty"` Level int `json:"level,omitempty"` Path string `json:"path,omitempty"` Children []*Channel `json:"children,omitempty"` CreatedAt time.Time `json:"created_at,omitempty"` UpdatedAt time.Time `json:"updated_at,omitempty"` Status string `json:"status,omitempty"` Permissions []string `json:"permissions,omitempty"` }

refer to the go sdk for these items

ianmuchyri · 2024-04-04T11:48:02Z

src/defs.ts

@@ -34,6 +29,9 @@ export interface Thing {
  owner?: string
  metadata?: Record<string, any>
  status?: string
+  createdAt?: string


Lets use snake case for these

ianmuchyri · 2024-04-04T11:48:40Z

src/defs.ts

@@ -18,14 +18,9 @@ export interface UsersPage {
  page: PageRes
 }

-export interface PageRes {


why are you deleting this interface?

ianmuchyri · 2024-04-04T11:49:37Z

src/channels.ts

+     *
+     */
+    const options: RequestInit = {
+      method: 'post',


Keep the method names in capital for all

Suggested change

method: 'post',

method: 'POST,

ianmuchyri · 2024-04-04T11:50:54Z

src/channels.ts

+        'Content-Type': this.contentType,
+        Authorization: `Bearer ${token}`
+      },
+      body: JSON.stringify(payload)


Suggested change

body: JSON.stringify(payload)

body: JSON.stringify({ subject: thingId, object: channelId })

Signed-off-by: wambuipixel <[email protected]>

ianmuchyri · 2024-04-05T12:58:56Z

examples/channels.ts

+const token = '<token>'
+
+mySdk.channels
+  .CreateChannel({ name: '<channelId>' }, token)


Suggested change

.CreateChannel({ name: '<channelId>' }, token)

.CreateChannel({ name: '<channelName>' }, token)

ianmuchyri · 2024-04-05T13:09:03Z

examples/channels.ts

+  .AddUserToChannel(
+    '<channelId>',
+    [
+      '<thingId>', '<thingId>'


Suggested change

'<thingId>', '<thingId>'

'<userId>', '<userId>'

ianmuchyri · 2024-04-05T13:09:19Z

examples/channels.ts

+  .RemoveUserFromChannel(
+    '<channelId>',
+    [
+      '<thingId>', '<thingId>'


Suggested change

'<thingId>', '<thingId>'

'<userId>', '<userId>'

ianmuchyri · 2024-04-05T13:18:29Z

src/channels.ts

+        'Content-Type': this.contentType,
+        Authorization: `Bearer ${token}`
+      },
+      body: JSON.stringify({ subject: thingId, object: channelId })


Suggested change

body: JSON.stringify({ subject: thingId, object: channelId })

body: JSON.stringify({ thing_id: thingId, channel_id: channelId })

ianmuchyri · 2024-04-05T13:19:38Z

src/channels.ts

+        'Content-Type': this.contentType,
+        Authorization: `Bearer ${token}`
+      },
+      body: JSON.stringify({ subject: thingId, object: channelId })


Suggested change

body: JSON.stringify({ subject: thingId, object: channelId })

body: JSON.stringify({ thing_id: thingId, channel_id: channelId })

ianmuchyri · 2024-04-05T13:21:56Z

src/channels.ts

+        const errorRes = await response.json()
+        throw this.channelError.HandleError(errorRes.error, response.status)
+      }
+      const channelData: Channel = await response.json()


Suggested change

const channelData: Channel = await response.json()

const updatedChannel: Channel = await response.json()

ianmuchyri · 2024-04-05T13:22:09Z

src/channels.ts

+        const errorRes = await response.json()
+        throw this.channelError.HandleError(errorRes.error, response.status)
+      }
+      const channelsData: ChannelsPage = await response.json()


Suggested change

const channelsData: ChannelsPage = await response.json()

const channels: ChannelsPage = await response.json()

ianmuchyri · 2024-04-05T13:22:29Z

src/channels.ts

+        const errorRes = await response.json()
+        throw this.channelError.HandleError(errorRes.error, response.status)
+      }
+      const channelData: ChannelsPage = await response.json()


Suggested change

const channelData: ChannelsPage = await response.json()

const channels: ChannelsPage = await response.json()

ianmuchyri · 2024-04-05T13:22:41Z

src/channels.ts

+        const errorRes = await response.json()
+        throw this.channelError.HandleError(errorRes.error, response.status)
+      }
+      const channelData: Channel = await response.json()


Suggested change

const channelData: Channel = await response.json()

const channel: Channel = await response.json()

ianmuchyri · 2024-04-05T13:22:56Z

src/channels.ts

+        const errorRes = await response.json()
+        throw this.channelError.HandleError(errorRes.error, response.status)
+      }
+      const channelData: Channel = await response.json()


Suggested change

const channelData: Channel = await response.json()

const newChannel: Channel = await response.json()

Signed-off-by: wambuipixel <[email protected]>

ianmuchyri

LGTM

wambui-pixel force-pushed the thingsupdate branch from 5544659 to 807b344 Compare April 3, 2024 12:56

wambui-pixel marked this pull request as ready for review April 3, 2024 12:59

Musilah requested changes Apr 3, 2024

View reviewed changes

wambui-pixel changed the title ~~NOISSUE - Updating Things.ts~~ NOISSUE - Updating Things and Channels Service Apr 4, 2024

wambui-pixel force-pushed the thingsupdate branch from 807b344 to 4efc7a9 Compare April 4, 2024 11:16

ianmuchyri requested changes Apr 4, 2024

View reviewed changes

wambui-pixel force-pushed the thingsupdate branch 3 times, most recently from 4442172 to 2edec88 Compare April 5, 2024 11:04

wambui-pixel added 11 commits April 5, 2024 14:41

updating things.ts

2dff6d0

Signed-off-by: wambuipixel <[email protected]>

updating things to use async functions

1fbc83d

Signed-off-by: wambuipixel <[email protected]>

Adding more functionalities to things.ts

f8ccdf0

Signed-off-by: wambuipixel <[email protected]>

Adding Linter

7792d5c

Signed-off-by: wambuipixel <[email protected]>

Update Channels.ts

79c90fa

Signed-off-by: wambuipixel <[email protected]>

resolving comments

439ad2f

Signed-off-by: wambuipixel <[email protected]>

Fixing Cl failing issues

9ab1085

Signed-off-by: wambuipixel <[email protected]>

Fix users.ts

7715936

Signed-off-by: wambuipixel <[email protected]>

Updating doc strings

3eede79

Signed-off-by: wambuipixel <[email protected]>

Updating token constant

668d111

Signed-off-by: wambuipixel <[email protected]>

Fixing Relation on things.ts

6faa013

Signed-off-by: wambuipixel <[email protected]>

wambui-pixel force-pushed the thingsupdate branch from 2edec88 to 6faa013 Compare April 5, 2024 11:56

wambui-pixel added 3 commits April 5, 2024 15:16

Fix Rebase error

3b9a2c6

Signed-off-by: wambuipixel <[email protected]>

Fix Lint errors on users.ts

3617ee2

Signed-off-by: wambuipixel <[email protected]>

Fix Lint errors on sdk.ts

d729aed

Signed-off-by: wambuipixel <[email protected]>

ianmuchyri requested changes Apr 5, 2024

View reviewed changes

wambui-pixel added 3 commits April 5, 2024 17:10

Fix requested changes

985e57a

Signed-off-by: wambuipixel <[email protected]>

Adding groupRelation to defs.ts

73c1143

Signed-off-by: wambuipixel <[email protected]>

Fix lint error in def.ts

7f08811

Signed-off-by: wambuipixel <[email protected]>

ianmuchyri approved these changes Apr 5, 2024

View reviewed changes

dborovcanin approved these changes Apr 5, 2024

View reviewed changes

dborovcanin merged commit 6b1d4b7 into absmach:main Apr 5, 2024
1 check passed

ianmuchyri mentioned this pull request Apr 5, 2024

Update JS SDK for Channels #17

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

NOISSUE - Updating Things and Channels Service #9

NOISSUE - Updating Things and Channels Service #9

wambui-pixel commented Mar 28, 2024 •

edited

Loading

ianmuchyri Apr 4, 2024

ianmuchyri Apr 4, 2024

ianmuchyri Apr 4, 2024

ianmuchyri Apr 4, 2024

ianmuchyri Apr 4, 2024

ianmuchyri Apr 4, 2024

ianmuchyri Apr 4, 2024

ianmuchyri Apr 5, 2024

ianmuchyri Apr 5, 2024

ianmuchyri Apr 5, 2024

ianmuchyri Apr 5, 2024

ianmuchyri Apr 5, 2024

ianmuchyri Apr 5, 2024

ianmuchyri Apr 5, 2024

ianmuchyri Apr 5, 2024

ianmuchyri Apr 5, 2024

ianmuchyri Apr 5, 2024

ianmuchyri left a comment

		import Things from './things'
		// import Groups from "./groups";

	body: JSON.stringify(payload)
	body: JSON.stringify({ subject: thingId, object: channelId })

	.CreateChannel({ name: '<channelId>' }, token)
	.CreateChannel({ name: '<channelName>' }, token)

	body: JSON.stringify({ subject: thingId, object: channelId })
	body: JSON.stringify({ thing_id: thingId, channel_id: channelId })

	const channelData: Channel = await response.json()
	const updatedChannel: Channel = await response.json()

	const channelsData: ChannelsPage = await response.json()
	const channels: ChannelsPage = await response.json()

	const channelData: ChannelsPage = await response.json()
	const channels: ChannelsPage = await response.json()

	const channelData: Channel = await response.json()
	const channel: Channel = await response.json()

	const channelData: Channel = await response.json()
	const newChannel: Channel = await response.json()

NOISSUE - Updating Things and Channels Service #9

NOISSUE - Updating Things and Channels Service #9

Conversation

wambui-pixel commented Mar 28, 2024 • edited Loading

What does this do?

Which issue(s) does this PR fix/relate to? NOISSUE

List any changes that modify/break current functionality

Have you included tests for your changes?

Did you document any new/modified functionality?

Notes

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ianmuchyri left a comment

Choose a reason for hiding this comment

wambui-pixel commented Mar 28, 2024 •

edited

Loading