Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement /credits #26

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Implement /credits #26

wants to merge 1 commit into from

Conversation

malloc3141
Copy link
Contributor

@malloc3141 malloc3141 commented Oct 14, 2024 •
edited
Loading

요약 *

It closes #19

피그마: https://www.figma.com/design/PpSN8r1RC76W0cfSGi1tMD/ar-007-Students?node-id=402-3332&node-type=frame&t=1fQCyofCNNSvJ9zV-0
구현하면서 생긴 디자인 관련 의견은 피그마 페이지에 달아두었습니다.

구현된 사항

  • credits 페이지
  • 포지션에 호버하면 뜨는 코멘트 같은거는 임시로 닉네임으로 채워두었음
  • font type이랑 weight 필요한 거 추가(fonts.ts)
  • 스팍스 컬러 상수 colors.ts에 추가
  • footer에서 만든 사람들 누르면 /credits로 이동

확인해야 할 사항

  • 디자인 상 BreadCrumb이 없는데 실제 페이지에도 필요 없는건지

스크린샷

이후 Task *

  • 없음

@malloc3141 malloc3141 added enhancement New feature or request frontend labels Oct 14, 2024
@malloc3141 malloc3141 requested a review from wjeongchoi October 14, 2024 17:13
@malloc3141 malloc3141 self-assigned this Oct 14, 2024
@wjeongchoi
Copy link
Contributor

디자인 수정되고 한번에 리뷰할게요

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wjeongchoi wjeongchoi Awaiting requested review from wjeongchoi

At least 1 approving review is required to merge this pull request.

Assignees

@malloc3141 malloc3141

Labels
enhancement New feature or request frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Impl /credits page
2 participants
@malloc3141 @wjeongchoi